Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESC db rotator docs #14620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ESC db rotator docs #14620

wants to merge 1 commit into from

Conversation

seanyeh
Copy link
Contributor

@seanyeh seanyeh commented Mar 28, 2025

Proposed changes

Add docs to the ESC mysql/postgres rotators

Unreleased product version (optional)

Related issues (optional)

@seanyeh seanyeh force-pushed the syeh/esc-aws-db-rotators branch from e1aca0d to ea7c7a9 Compare March 28, 2025 21:49
@pulumi-bot
Copy link
Collaborator


## Setup

In order for ESC to connect to your database, you will need to use one of our connectors. Currently, only the AWS Lambda connector is supported.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if there is a better way to word this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should be introducing the term "connector" before we're fully committed to it - I think in Pat's doc they were called "callbacks", but that might be too generic, as this is specifically a "rotation agent", another term we used to talk about this concept. So we should 100% align before putting it out there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see that it's already baked into the schema in the PR adding the rotators - https://github.com/pulumi/pulumi-service/pull/26199/files

I probably just missed the discussion

@seanyeh seanyeh marked this pull request as ready for review March 31, 2025 14:05
@seanyeh seanyeh requested a review from a team as a code owner March 31, 2025 14:05
@seanyeh seanyeh requested a review from nyobe March 31, 2025 14:05
@IaroslavTitov
Copy link
Contributor

Are there docs on setting up "connectors"/"rotation agents"? We need to link to docs and pulumi program that sets it up when talking about it, otherwise it's super confusing.


| Property | Type | Description |
|-------------|-----------------------------------------------------|----------------------------------|
| `connector` | [DatabaseConnectorConfig](#databaseconnectorconfig) | Database connector configuration |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing other properties here

          database: dbname
          host: <database host>
          port: 3306
          managingUser:
            username: managinguser
            password:
              fn::secret: mypassword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants