-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESC db rotator docs #14620
base: master
Are you sure you want to change the base?
Add ESC db rotator docs #14620
Conversation
e1aca0d
to
ea7c7a9
Compare
Your site preview for commit ea7c7a9 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-14620-ea7c7a96.s3-website.us-west-2.amazonaws.com. |
|
||
## Setup | ||
|
||
In order for ESC to connect to your database, you will need to use one of our connectors. Currently, only the AWS Lambda connector is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if there is a better way to word this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should be introducing the term "connector" before we're fully committed to it - I think in Pat's doc they were called "callbacks", but that might be too generic, as this is specifically a "rotation agent", another term we used to talk about this concept. So we should 100% align before putting it out there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I see that it's already baked into the schema in the PR adding the rotators - https://github.com/pulumi/pulumi-service/pull/26199/files
I probably just missed the discussion
Are there docs on setting up "connectors"/"rotation agents"? We need to link to docs and pulumi program that sets it up when talking about it, otherwise it's super confusing. |
|
||
| Property | Type | Description | | ||
|-------------|-----------------------------------------------------|----------------------------------| | ||
| `connector` | [DatabaseConnectorConfig](#databaseconnectorconfig) | Database connector configuration | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing other properties here
database: dbname
host: <database host>
port: 3306
managingUser:
username: managinguser
password:
fn::secret: mypassword
Proposed changes
Add docs to the ESC mysql/postgres rotators
Unreleased product version (optional)
Related issues (optional)